Add recommendations on non-idempotent operations to vshard docs #5252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuniq
force-pushed
the
5242-deduplication
branch
from
9db369a to
d0c7e23
Compare
xuniq
force-pushed
the
5242-deduplication
branch
from
d0c7e23 to
e601387
Compare
xuniq
force-pushed
the
5242-deduplication
branch
from
e601387 to
acd7589
Compare
xuniq
force-pushed
the
5242-deduplication
branch
from
acd7589 to
d3b7c4a
Compare
xuniq
force-pushed
the
5242-deduplication
branch
from
d3b7c4a to
8269db6
Compare
There was a problem hiding this comment.
Thanks for the detailed description!
Please, consider my comments below. I also suggest asking @Totktonada to take a look at this doc.
| - Read requests can be executed repeatedly. | ||
| For this purpose, :ref:`vshard.router.call() <router_api-call>` (with ``mode=read``) uses the ``request_timeout`` parameter | ||
| (since ``vshard`` 0.1.28). | ||
| It is necessary to pass the ``request_timeout`` and ``timeout`` parameters together, with the following requirement: |
There was a problem hiding this comment.
Let's please add request_timeout option to router API reference here: https://docs.d.tarantool.io/en/doc/5242-deduplication/reference/reference_rock/vshard/vshard_router/#lua-function.vshard.router.call
| end | ||
| box.commit() | ||
|
|
||
| For update and upsert requests, you can create a *deduplication space* where the request IDs will be saved. |
There was a problem hiding this comment.
Let's state a bit more explicitly that for now this can be only implemented by the user, there is no support of deduplication from tarantool, but it might appear later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5242
Deployment: https://docs.d.tarantool.io/en/doc/5242-deduplication/platform/sharding/vshard_admin/#deduplication-of-non-idempotent-requests